This report lives on GitHub. You are reading it in Luma’s tracker. To add to it, reply there.Open on GitHub

GitHub #39 Public tree: unit tests and the build gate reference files that are not published

robinterlinden-netizenon GitHub · 7 days ago

Summary
Running the full unit suite as scripts/os/check-source-before-drop.sh does (Fedora 44 aarch64, main 4a736ac) leaves two errors that come from files missing in the public tree, and the gate itself calls a missing script:

tests/unit/test_luma_appkit_conformance.py (APPLICATION_SHEETS) lists src/luma-layouts/style/layouts.css and src/luma-reel/style/reel.css. Neither path exists on main or in its history → FileNotFoundError in test_application_sheets_conform.
tests/unit/test_luma_appkit_families.py::test_accepted_deviations_are_documented reads docs/developer/kit/lumaui-deviations.md, which does not exist (it is also referenced from src/luma-platform/appkit/luma_appkit/content_cards.py and luma-appkit-base.css).
scripts/os/check-source-before-drop.sh runs bash tools/check-repository.sh, which is not in the tree, so the gate cannot pass without --backfill.

Expected
Either publish these files, or have the tests/gate cover only what is in the public tree. We did not change or skip these tests in our build.

Found while building Luma from source on a Fedora 44 aarch64 VM (Luma's FP6 twin setup).

Nobody has replied yet

The conversation about this report is on GitHub, so that is where a reply reaches the people in it. If it happens to you too and you would rather not use GitHub, file it here and mention GitHub #39.

Reply on GitHub Report it here